ABTech / tracker

Carnegie Mellon Activities Board Technical Committee Tracker
abtech.org
22 stars 29 forks source link

Add :blob-emotes: #526

Open NoRePercussions opened 1 year ago

NoRePercussions commented 1 year ago

:party-blob: demo

What?

Adds the following emotes to tracker:

(Inconsistent) names are taken from Slack so you can copy-paste from it.

Why??

It's iconic.

Potential Problems

wjiang42 commented 1 year ago
NoRePercussions commented 1 year ago

https://cmuabtech.slack.com/archives/CKLMNB5PX/p1696632545513259

The most recent commit definitely needs review... this site seems pretty JS-light so I can't figure out how you'd prefer it to be done.

This also helps with the clutter a bit, since like nicknames it won't be visible to non-members.

DaAwesomeP commented 1 year ago

Yeah any and all assets need to be downloaded into the repo. Especially since Slack does not specifically host these asserts for others to use, those links are highly likely to break. In general things break if you rely on external resources; this was a major part of fixing abtech.org.

May I suggest a more performant/controllable alternative? Add a specific emote field to events that gets appended to the end of the event title when appropriate.

If we do stick with the scanning DOM method, then we still need to scrub the emotes server-side when they shouldn't appear.