search

ABaumher / galaxy-integration-steam

Integration with Steam for Galaxy
Other
770 stars 18 forks source link

Mac build fix #11

Open bgebhardt opened 1 year ago

bgebhardt commented 1 year ago

@ABaumher here's my pull request

I inadvertently committed and reverted some other stuff too. Those are the first 2 commits.

ABaumher commented 1 year ago

For the pip-tools 5.4.0 issue, the old code used pip 22.0.4 so that wasn't an issue. Currently that is set at https://github.com/ABaumher/galaxy-integration-steam/blob/995f7e6f379de63dd74e8643a419019517e5acd2/requirements/install.txt#L2

did you run pip install -r dev.txt in your virtual environment? if so, that line isn't working properly for whatever reason. I know a later pip would break on our code because some of our modules drop support for python 3.7 and their old versions use deprecated calls, which newer pip versions will not allow.

I made a couple changes on MacOS_Fix branch which should hopefully fix the certificate issue without requiring you install the certificates manually. It also grants execute permission on protoc for all users when you run inv InstallProtoc. Unfortunately, it only applies to a new protoc install, it won't work on an existing version. I probably could change that to work there as well. let me know if they work. Unfortunately you may need to test it on a different Mac if all your settings are already working, or uninstall python and the certificates and try again.

Disclaimer: i have done almost no programming on a Mac, so idk if these will work. The best i can do is ensure the InstallProtoc change would work on Linux and the underlying call is the same, but idk.

ABaumher commented 1 year ago

I'm rewriting the comments, and i'll make sure to use your inputs as a base for the MacOS section. Unfortunately, the changes are on my home computer and i didn't push them, so i can't access them for a few hours. If the certifi and os.chmod fixes work, i can simplify the macos install instructions.

ABaumher commented 1 year ago

I have hopefully fixed all of this on https://github.com/ABaumher/galaxy-integration-steam/commit/e46968facbc484950c8365fbf5df12bb7280fd50. Let me know if this is correct for you.