ABaumher / galaxy-integration-steam

Integration with Steam for Galaxy
Other
760 stars 19 forks source link

Family sharing #18

Open ListenToTheRain opened 1 year ago

ListenToTheRain commented 1 year ago

Hello, I have an issue. My steam account, which is linked to gog galaxy, has games available to me via family sharing. And when I installed this new integration and linked my steam account to the gog for the first time (after deleting the old integration's files and storage) these family-sharing games synched with my gog galaxy library (they are under the Subscriptions tab). After that, I got new games, that are available to me via family sharing, but they don't want to synch with my gog library. I already restarted gog galaxy a few times, and the integration synched new games from my own steam account, but not these new games available via family sharing. The old integration checked and resynched these family-sharing (subscription type) games from time to time.

ABaumher commented 1 year ago

Well, we haven't changed how we get that information so it should not change, but if you provide your log i can look to see if something broke. There's a function called tick that would do those periodic tasks. It should call the same functions we use to get the information after you login so it should work there as well.

ListenToTheRain commented 1 year ago

plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log Hi. here is the log. I hope this is what you needed.

ABaumher commented 1 year ago

I want to give you an update so you don't think i'm abandoning this issue. I have found the source for where gog tells us to get game subscriptions. As far as i can tell, gog has to call us to get these to update, and i don't know if it ever does so during normal run. I'd assume it does, but idk. If it does not, restarting the client should force this to occur eventually.

I can look for the games in your log, but i'd need to know the name of these games that aren't appearing. I can use names in another language if that's easier for you, but i need to know which language the name is in. if their ids appear in your log but we aren't properly handling them, this is something we can fix. if steam does not send them we obviously cannot fix it, but i'm guessing this isn't the case. The third option is that we do get them but the old code is horribly broken in ways that aren't easy to see, so the only way to fix them is to rewrite the code in a cleaner way and find what's missing.

ListenToTheRain commented 1 year ago

Hello. Restarting GOG Galaxy doesn't help. The games are: Song of Farca We. The revolution

ABaumher commented 1 year ago

The ids for both apps do not appear in your log. That doesn't mean you don't have them, but it definitely makes finding out why they aren't there a lot harder. It may mean our parsing code doesn't find them or it's a result of you having a large library and the old code being bad at handling big libraries.

ABaumher commented 1 year ago

If it's a large library issue the best i can do is hope the refactor cleans it up so this isn't an issue anymore. I'm working on it