search

ABaumher / galaxy-integration-steam

Integration with Steam for Galaxy
Other
770 stars 18 forks source link

betterproto all the things; also fixes cache issue #19

Closed don-de-marco closed 1 year ago

don-de-marco commented 1 year ago

@ABaumher the fix for the cache issue is here: https://github.com/ABaumher/galaxy-integration-steam/pull/19/files#diff-8566e9cb92291fad49961305df673326ab3c3dbe47f2daf0e007074a96d2692e

removing the db file is no longer necessary with this change

ABaumher commented 1 year ago

Updating the protoc to 22.0 removes the need for the proto2 header. Normally this would be an issue but betterproto takes over the parsing so we can use a newer version. I think 22.3 introduced a breaking change but it might still be able to handle it, idk.

ABaumher commented 1 year ago

@don-de-marco can you look over the changes i made to your pr before i merge it all in? just want to make sure you're ok with them.

don-de-marco commented 1 year ago

lgtm, you can merge anytime

The only nitpick I have is you re-adding the to_TwoFactorMethod: I Ctrl-F'ed the whole code base and there was no reference to this function anywhere, not even in a comment or something. Could you please double check that and remove the function if it's indeed no longer needed?