Closed MisterZeus closed 1 year ago
MisterZeus
commented
1 year ago Good points and thanks for the info, I didn't realise those python dependency modules were so unprofessionally updated :-D
Don't worry about accepting this PR, I did not get the pytest modules actually fully running, so not much value in it right now. Not sure when I'll get time/appetite to look at this next.
ABaumher
commented
1 year ago yeah, i really do not like Python, lol. I come from a background where breaking changes are considered taboo, for lack of a better word. If you must have them, you document how to migrate to the latest version. Otherwise, you get extremely fragmented code, but python seems to embrace this concept. I'm not entirely sure why.
MisterZeus
commented
1 year ago latest commit should be cleaner, shout if problems/questions ^_^
ABaumher
commented
1 year ago Looks good, for the most part. There is a merge conflict now that the readme has been updated to properly explain the beta. If you could merge that in to your PR branch and update all the stuff there (and any spelling or capitalizations i screwed up like you did for the ReadMe here), i'll merge it in. But not today, i'm tired af
MisterZeus
commented
1 year ago no worries, conflict fix is done whenever you feel like it :-)
Sorry, i just saw this now. A lot of the modules have specific versions because python and python developers love breaking changes. I have no idea if these are all necessary or if some of them have made sure not to make any breaking changes and we could just use a later version. I know protobuf 3.20 introduces a breaking change, for example. @TheSentry is looking at our pytest now, i've mentioned this PR so he could look if they are useful.
I need to update the readme, which will happen once the last patch passes our tests. We're going to have a zip release, so installing it for yourself is going to be monumentally easier - unzip the archive, place it in the right location, and go.