search

ABaumher / galaxy-integration-steam

Integration with Steam for Galaxy
Other
743 stars 17 forks source link

Plugin crash on syncing for first time #9

Open engiefox opened 1 year ago

engiefox commented 1 year ago

On trying to sync Steam for the first time, plugin displays "Not Responding" very briefly before crashing with "Plugin crashed Retry" displayed. Retrying or restarting GOG allows Steam to sync as normal, but no bookmark for games is made. gog_logs.zip

engiefox commented 1 year ago

Adding several free games to my library caused another crash, again with the "Unrecognized App Structure" line showing in the logs. plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log

ABaumher commented 1 year ago

public_only is unexpected because in the requests we send for the information, only_public is marked obsolete and unsent. I have no idea why valve is giving it to us. Also, 520 Is the beta for TF2, it's long been obsolete. 479520 does not exist as far as i can tell. I'm guessing you grabbed TF2 to test the free game import?

engiefox commented 1 year ago

No, I've had TF2 since before it was F2P

engiefox commented 1 year ago

479520 is apparently a hidden app that comes with several Magicka bundles, what specifically it is, idk. edit: https://steamdb.info/app/479520/subs/

ABaumher commented 1 year ago

That does explain why you had the beta lol. I'm wondering if these hidden/ legacy apps are causing issues. It might explain why we've had so much of an issue tracking down that other user's errors (apologies, afk and don't recall the handle). If it's erroring in the stats cache we'd never log it and that's why your log files just abruptly end

On Tue, May 30, 2023, 4:27 PM engiefox @.***> wrote:

No, I've had TF2 since before it was F2P

— Reply to this email directly, view it on GitHub https://github.com/ABaumher/galaxy-integration-steam/issues/9#issuecomment-1569048594, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASX2DPGKVTN7RUU3EW3CQ4TXIZJ3RANCNFSM6AAAAAAYRMGLWI . You are receiving this because you commented.Message ID: @.***>

engiefox commented 1 year ago

It's always short ~50 achievements compared to what my Steam profile lists as well, even after trying what @wwMRd posted. I wonder if it has to do with games that aren't listed anymore, but maybe still have achieves on my profile?

ABaumher commented 1 year ago

That actually sounds like it might be the case. We only get games you have a license for so if that's not the case we don't really have a way for steam to give us that info without checking every game steam has, which is basically impossible

On Tue, May 30, 2023, 5:30 PM engiefox @.***> wrote:

It's always short ~50 achievements compared to what my Steam profile lists as well, even after trying what wwMRd posted. I wonder if it has to do with games that aren't listed anymore, but maybe still have achieves on my profile?

— Reply to this email directly, view it on GitHub https://github.com/ABaumher/galaxy-integration-steam/issues/9#issuecomment-1569129528, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASX2DPHNYU5BFEXHXMTG2NDXIZRHZANCNFSM6AAAAAAYRMGLWI . You are receiving this because you commented.Message ID: @.***>

ABaumher commented 1 year ago

Do you have any games you know you no longer own but have achievements for? I can find the appid from their the steam page or via steamdb and see if it's in your log anywhere

engiefox commented 1 year ago

Unfortunately, no. I wouldn't even know where to begin to find out. I've been on Steam for 12 years, so who knows what might have been removed from Steam in that time.

engiefox commented 1 year ago

I know I've removed a few F2P games from my library, but I don't think any of those had achievements and it's hard to remember what any of them were it's been so long.

ABaumher commented 1 year ago

As for the first time crash, i think @Amarinth found what happens there (something about gog thinking we're done and we aren't) but I'll need to more thoroughly log everything to see where we crash. It's not high on my list of fixes but I'll get to it eventually.

One of the problems with trying to kill all the little bugs now is they're often the result of really bad code and refactoring would fix it. So i can either focus on a full refactor, which will take longer, or find these and bandaid fix them, which is quicker but delays the refactor and might expose more bugs. If you didn't get this by now, the code i inherited is a nightmare.