search

ABckh / zed-java-eclipse-jdtls

Eclipse Public License 2.0
29 stars 3 forks source link

Fix method completion label highlighting #5

Closed valentinegb closed 7 months ago

valentinegb commented 7 months ago

With the changes made in 39175e5, highlighting of the return type of methods in completion labels has stopped working. For highlighting to work in completion labels, the code (name of the field) must be valid Java code that can be parsed and highlighted by Tree Sitter. So, because of this, it must stay how it was prior to 39175e5. However, we can still change the text that is displayed in the label, so in this PR the return type and method name appear to be in the same format as 39175e5, just with valid code to parse beforehand.

valentinegb commented 7 months ago

Whoops, I probably should have anticipated there would be a conflict 😅 I'll get that fixed as soon as I can (might be between 10 to 50 minutes, sorry)

valentinegb commented 7 months ago

Alright that's been fixed, sorry again

ABckh commented 7 months ago

Great job! Thank you for your effort!