search

ABenassi87 / ngx-text-diff

A Text Diff component for Angular
https://ngx-text-diff.herokuapp.com/home
50 stars 44 forks source link

Angular 10 Ivy #56

Open Dovernh opened 3 years ago

Dovernh commented 3 years ago

This likely means that the library (ngx-text-diff/lib/ngx-text-diff.module) which declares NgxTextDiffModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy

Dovernh commented 3 years ago

So i created a new Angular 10 project, copied parts of the code and i got things to work.

gethari commented 3 years ago

So i created a new Angular 10 project, copied parts of the code and i got things to work.

Would you mind sharing what you did ?

lauramgran commented 3 years ago

Hello! I am also having problems with this component when updating it to angular 10. I have disabled ivy to avoid problems and they are still incompatible Have you managed to use this component in angular 10?

Thanks

Dovernh commented 3 years ago

So not the best solution, but it enabled to use the functionality. If you look at the code in GitHub you will see code that is 2 years old (it is the code which does the diff’ing). That code is good (synchronize scroll doesn’t work for me). The newer code which is a wrapper around the diff code has some issues I think. So what I did was removed the wrapper code and pointed my angular code at the old code angular selectors. I have made other code adjustments that are specific to my requirements. Also I made the diff code on its own module so it is no longer a npm lib. I was hoping the author would eventually fix the code so I could toss my temp solution and go back to the npm module On Nov 17, 2020, 11:32 AM -0500, lauramgran notifications@github.com, wrote:

Hello! I am also having problems with this component when updating it to angular 10. I have disabled ivy to avoid problems and they are still incompatible Have you managed to use this component in angular 10? Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

gethari commented 3 years ago

So not the best solution, but it enabled to use the functionality. If you look at the code in GitHub you will see code that is 2 years old (it is the code which does the diff’ing). That code is good (synchronize scroll doesn’t work for me). The newer code which is a wrapper around the diff code has some issues I think. So what I did was removed the wrapper code and pointed my angular code at the old code angular selectors. I have made other code adjustments that are specific to my requirements. Also I made the diff code on its own module so it is no longer a npm lib. I was hoping the author would eventually fix the code so I could toss my temp solution and go back to the npm module … On Nov 17, 2020, 11:32 AM -0500, lauramgran @.***>, wrote: Hello! I am also having problems with this component when updating it to angular 10. I have disabled ivy to avoid problems and they are still incompatible Have you managed to use this component in angular 10? Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

I did the same for angular 10

ABenassi87 commented 3 years ago

Hi, I apologize for the delay, but I don't have time to update the library because I'm so busy. If anyone wants to update the library and create a pull request I would really appreciate it. Regards