ABoyWithALaptop / df-frontend-2023

dwarvesf workshop Front-end
0 stars 0 forks source link

Submission for assignment 1. #1

Closed ABoyWithALaptop closed 1 year ago

ABoyWithALaptop commented 1 year ago

https://assignment-01-djmq.onrender.com/

trankhacvy commented 1 year ago

Hello @ABoyWithALaptop , great work!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Choose clear and descriptive names for your variables, classes, or IDs. Names like stdHeight, searchRes, or closeAct are not very helpful.

  2. While it's not mandatory, using meaningful names for classes and IDs makes it easier for others to understand your code. In HTML/CSS, it's a best practice to use lowercase letters for classes and IDs. You can check this link for more naming conventions.

  3. It would be better if you could reset the "Add book" form after creating a new book.

  4. Your CSS and JavaScript code looks a bit crowded. It's a good idea to insert an empty line between two functions or two sections of CSS to make it more readable.

  5. You've added a delay when searching, which is a good practice. However, it might be a bit too long. Ideally, the delay should be around 250 to 300 milliseconds.

  6. We encourage you to add comments to your issue to describe what you have done in your assignment. This will make it easier for us to review your work and understand your changes.

Keep up the great work!

ABoyWithALaptop commented 1 year ago

thank you for your review Mr. @trankhacvy , I will update your advice in the next assignments in this course.