Open ABoyWithALaptop opened 1 year ago
Hi @ABoyWithALaptop,
Result: ✅
If a book's topic is set to "Programming," the selection is not pre-filled in the edit modal.
There is a bug where if a user clicks "Edit" for a book, closes the modal, and then clicks "Add New," the edit modal will display the details of the previously selected book instead of adding modal.
The password schema should has regular expression and has required field to test with the required from assignment's requirements. https://github.com/ABoyWithALaptop/df-frontend-2023/blob/78fed9a5494c1686baec9f51cd6b984469c85397/assignment-5/src/app/login/page.tsx#L12-L15
Should be named with isAuthenticated
instead of login
https://github.com/ABoyWithALaptop/df-frontend-2023/blob/78fed9a5494c1686baec9f51cd6b984469c85397/assignment-5/src/app/login/page.tsx#L24-L25
For the validation schema can consider separate to a constant folder, and reuse them on your components https://github.com/ABoyWithALaptop/df-frontend-2023/blob/78fed9a5494c1686baec9f51cd6b984469c85397/assignment-5/src/app/sign-up/page.tsx#L14-L33 https://github.com/ABoyWithALaptop/df-frontend-2023/blob/78fed9a5494c1686baec9f51cd6b984469c85397/assignment-5/src/components/modals/AddBookModal.tsx#L17-L21
Should create a generic modal component to receive initial data value for edit or adding
src/components/modals/AddBookModal.tsx
...