search

ABuffSeagull / eslint-import-resolver-parcel

Parcel import resolution plugin for eslint-plugin-import
MIT License
12 stars 2 forks source link

Feature/updates #2

Closed TDKRage closed 5 years ago

TDKRage commented 5 years ago

Hi There Mr. Seagull.

I've added Jest testing to the project and also the ability to customize the extensions that can be resolved.

As parcel will most likely be expanding its recipes. I hope this helps.

used resolve.Sync options https://github.com/browserify/resolve#resolvesyncid-opts rather than looping through an array of extensions.

would like to add support for resolving index files from folders, don't know if that is something you'd be interested in. As I know its primarily a Webpack thing. But would make migration from Webpack to Parcel and visa versa much easier.

Looking forward to your feedback ;)

ABuffSeagull commented 5 years ago

Mr. Seagull

Oh, so formal :heart:

used resolve.sync options for filetype extensions

oh wow, I totally skipped over it. Yeah, we'll definitely use that. Good catch :+1:

add testing with jest

you even added testing? thank you so much!

As far as adding functionality for finding index files, yeah, I can do that, shouldn't be hard.

The only things that need to change with your pull request is to add the tests to the linting, make sure you use tabs, not spaces, and use yarn, not npm.