search

AButler / upload-release-assets

GitHub Action to upload assets to a Release
MIT License
59 stars 20 forks source link

bump using node20 #23

Closed Borda closed 11 months ago

Borda commented 11 months ago

trying to address GH warning: The following actions uses node12 which is deprecated and will be forced to run on node16: AButler/upload-release-assets@v2.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

AButler commented 11 months ago

Superceded by #31 - thanks for this @Borda - I've been meaning to get this action up to date for while.

Borda commented 11 months ago

Not sure why you need to close this PR and create identical later? 😕

AButler commented 11 months ago

@Borda I needed it rebased so it would run the CI and it was quicker just to do it in the repo than your fork. Apologies if it looked bad, was just doing it for speed

Borda commented 11 months ago

You could ping me or simply merge main branch lol

Especially if you enable update suggestions in the setting, that is even faster than creating a new PR then if you squash & merge this merged master is not visible and you still preserve linear git history