search

ACC-Hymns / acchymns-web

Central ACC Hymnal for many song books used across the ACC
https://www.acchymns.app
3 stars 3 forks source link

[Feature] enable bookmarks to load while offline #85

Open ruthrootz opened 1 year ago

ruthrootz commented 1 year ago

At least on iOS, bookmarks don't load when offline.

Christoffyw commented 1 year ago

I can't reproduce this issue. Is this happening on the latest production version?

ruthrootz commented 1 year ago

@Christoffyw Looks like it only happens if the app hasn't been opened in a while (a few hours to a day or more?). For example, we have bad reception at our church, so opening the app in church usually results in a blank Bookmarks page unless the user had the app open before coming to church.

ruthrootz commented 1 year ago

I can't reproduce this issue. Is this happening on the latest production version?

Yes, 2.0.2

Nomalah commented 1 year ago

@Nomalah I'm hesitant to get rid of my Hungarian and Zbirka bookmarks to test your theory 😆 But that sounds very plausible.

Nomalah commented 1 year ago

This also might be inadvertently fixed when I fix #65, I'm reworking the remote books a bit, and I have a guess that it might end up fixing this.

Nomalah commented 1 year ago

I'll turn off my data and test that way, we'll see if we can reproduce over here. Of note, is that the current production version caches the metadata for books and songs for an hour, so that's likely what you're seeing.

Looks like it only happens if the app hasn't been opened in a while (a few hours to a day or more?)

Nomalah commented 1 year ago

My testing shows that add-on books without a connection results in missing bookmarks (instead of unavailable or similar)

ruthrootz commented 1 year ago

Hmmm. Here's what it looks like for me...

When I open the app with airplane mode on (after a few hours of the app being closed): image image

Reopening the app with cellular/wifi connected: image image