ACCESS-Cloud-Based-InSAR / dem-stitcher

Download and merge DEM tiles
Apache License 2.0
43 stars 15 forks source link

URL Fixes for Glo-30 and SRTM-v3 #49

Closed cmarshak closed 1 year ago

cmarshak commented 1 year ago

Fixes #48 and srtm_v3 urls in the DEM tiles.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

cmarshak commented 1 year ago

Hey @jhkennedy

The static analysis is failing. Can't totally figure out the asf actions since I am bad with bash redirection: https://github.com/ASFHyP3/actions/blob/main/.github/workflows/reusable-flake8.yml#L29-L31

We can talk about it tomorrow when we meet. The second line (approximately) seems to be fine on my machine: flake8 --max-line-length=120 --import-order-style=pycharm --statistics --application-import-names dem_stitcher


Also, I added 3.11 to the github actions - probably should have had a separate pull request... did not modify the setup.py which I think will actually impact pypi and conda.

jhkennedy commented 1 year ago

@cmarshak these are the errors that flake8 is reporting:

 ./dem_stitcher/stitcher.py:156:11: E275 missing whitespace after keyword
./dem_stitcher/stitcher.py:157:11: E275 missing whitespace after keyword
./dem_stitcher/stitcher.py:213:11: E275 missing whitespace after keyword
./dem_stitcher/geoid.py:58:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:14:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:28:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:29:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:30:11: E275 missing whitespace after keyword
./tests/test_rio_tools.py:40:11: E275 missing whitespace after keyword
./tests/test_geoid.py:28:11: E275 missing whitespace after keyword
./tests/test_geoid.py:55:15: E275 missing whitespace after keyword
./tests/test_window.py:81:11: E275 missing whitespace after keyword
./tests/test_window.py:100:11: E275 missing whitespace after keyword
./tests/test_window.py:126:11: E275 missing whitespace after keyword
./tests/test_window.py:144:11: E275 missing whitespace after keyword
./tests/test_window.py:162:11: E275 missing whitespace after keyword
./tests/test_window.py:205:11: E275 missing whitespace after keyword
./tests/test_missing.py:30:11: E275 missing whitespace after keyword
./tests/test_missing.py:47:11: E275 missing whitespace after keyword
./tests/test_missing.py:72:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:98:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:143:11: E275 missing whitespace after keyword
./tests/test_stitcher.py:196:11: E275 missing whitespace after keyword
23    E275 missing whitespace after keyword
jhkennedy commented 1 year ago

@cmarshak yes, that flake8 command looks correct.

cmarshak commented 1 year ago

Thank you, Joe - It took you reminding me (I am sorry for wasting your time) to remember that assert keyword is not being correctly tracked by my VS Code. assert(<blah>) is not ok anymore.

Thanks again. Will fix all.