search

ACCESS-Community-Hub / Land-ancillary-creation

A repository containing scripts to create ancillary files for land surface models for ACCESS
0 stars 0 forks source link

init commit for working ancil suite emulator, but without ants_src #11

Open matlipson opened 1 week ago

matlipson commented 1 week ago

This branch successfully emulates the offline/RAS suite ancillary generation process for land mask and land cover fractions. However, I have not yet included the ants_src files that it draws from, as I'm still unsure of the licensing of ANTS.

If you have access to rp23 it should work out of the box.

Otherwise if you have access to the MOSRS ants repository, you can check out the branch used by MartinBests/Siyuan's offline version with:

svn co https://code.metoffice.gov.uk/svn/ancil/ants/branches/dev/martinbest/r13910_ancil_ants_JULES_vn1.1.0/

Then update run_ancil_lct.sh variable ANTS_SRC_PATH= to point to your checkout src r13910_ancil_ants_JULES_vn1.1.0/bin. Then qsub run_ancil_lct.sh should work.

Whyborn commented 1 week ago

Great to see that this is working so quickly. I think given that this repository is likely to be a temporary measure, I'm happy to merge this into the main branch primarily for visibility.

ccarouge commented 2 days ago

@matlipson A small comment from me, if you could add some explanations of the steps in the run_ancil_lct.sh file that would be great. I'm guessing checking the documentation for each of the ANTS code used would give the information but it would be great to have a bit more info directly in the script.

In details, I have no idea what ancil_lct.py does. ancil_general_regrid.py, I can guess. ancil_lct_postproc_c4.py, my only guess is that it has to do with C4 grasses but not sure why a post-processing step is needed and what it does. I'm guessing "lct" stands for land cover transformation. I'm guessing all these Python codes are from the official ANTS package and not in the contributions from the community, is that correct?

matlipson commented 2 days ago

Fair points, thanks for this feedback, I can include short descriptions of what each "app" does.

But first it would be good to get your guidance on the following.

Since I did this pull request I've gone ahead and created scripts for the entire JULES ancil generation process, i.e. not just land cover (lct), but also things like canopy heights, lai, albedo, dust, soil parameters etc.

I have it working as seperate scripts (as with the lct file here), but also in a single large script. This second option is much easier for users as the dependencies are worked out for them, just need to run one bash script.

Should this large script supersede this current branch which only does one task? Perhaps this is worth discussing at the next WG meeting (but I won't be there on the 4th).