search

ACCESS-NRI / ACCESS-OM2

ACCESS-OM2: ACCESS Ocean-Sea Ice Model
Apache License 2.0
5 stars 0 forks source link

Depend on openmpi instead of nci-openmpi and add restart reproducibility #49

Closed harshula closed 3 months ago

harshula commented 4 months ago
harshula commented 4 months ago

This change was triggered by https://github.com/ACCESS-NRI/spack-packages/issues/61 .

github-actions[bot] commented 3 months ago

The model version in the spack.yaml has not been updated. Either update it manually, or comment the following to have it updated and committed automatically:

aidanheerdegen commented 3 months ago

!bump minor

github-actions[bot] commented 3 months ago

:white_check_mark: Version bumped from 2023.11.23 to 2023.11.24 :white_check_mark:

github-actions[bot] commented 3 months ago

This ACCESS-NRI/ACCESS-OM2 model will be deployed with the following versions:

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

aidanheerdegen commented 3 months ago

Pre-release deployment is reporting

/bin/bash: line 5: /g/data/vk83/prerelease/apps/spack/0.20/spack-config/spack-enable.bash: No such file or directory

Despite this change

https://github.com/ACCESS-NRI/build-cd/pull/31/files

Seems that on gadi it is still called spack-start.sh

$ ls /g/data/vk83/prerelease/apps/spack/0.20/spack-config/
LICENSE  README.md  spack-start.bash  tools  v0.20
CodeGat commented 3 months ago

Might need to check the version tagged in config/versions.json in the morning - is it spack-enable.bash in that tag? Or spack-start?

github-actions[bot] commented 3 months ago

The model version in the spack.yaml has not been updated. Either update it manually, or comment the following to have it updated and committed automatically:

github-actions[bot] commented 3 months ago

This ACCESS-NRI/ACCESS-OM2 model will be deployed with the following versions:

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

CodeGat commented 3 months ago

!bump major

github-actions[bot] commented 3 months ago

:white_check_mark: Version bumped from 2023.11.24 to 2024.03.0 :white_check_mark:

github-actions[bot] commented 3 months ago

This ACCESS-NRI/ACCESS-OM2 model will be deployed with the following versions:

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

aidanheerdegen commented 3 months ago

We shouldn't merge until we have done some performance testing, confirming the impact is minimal

CodeGat commented 3 months ago

Good point @aidanheerdegen - I've requested changes so it shouldn't be able to merge

aidanheerdegen commented 3 months ago

Seems the pre-release build is still using nci-openmpi

$ grep openmpi /g/data/vk83/prerelease/apps/spack/0.20/spack/var/spack/environments/access-om2-2024_03_0-4/spack.lock                                 
          "name": "nci-openmpi",
          "name": "nci-openmpi",
      "name": "nci-openmpi",
        "path": "/apps/openmpi/4.0.2",
          "openmpi/4.0.2"
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",
          "name": "nci-openmpi",
CodeGat commented 3 months ago

What does this mean, exactly...?

CodeGat commented 3 months ago

@harshula

github-actions[bot] commented 3 months ago

This ACCESS-NRI/ACCESS-OM2 model will be deployed with the following versions:

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

CodeGat commented 3 months ago

@harshula The openmpi thing was fixed - we hadn't tagged the nci-openmpi->openmpi fix in spack-config.

harshula commented 3 months ago

Hi @CodeGat , Is there anything else we need to do?

CodeGat commented 3 months ago

I assume some kind of performance testing of some kind before proper deployment

access-hive-bot commented 3 months ago

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/access-om2-bit-repro-testing/1960/1