Closed aidanheerdegen closed 6 months ago
The model version in the spack.yaml
has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:
!bump major
for feature releases!bump minor
for bugfixesI think I've used the right syntax for this, but happy to be told otherwise.
The other option is that we add this as the default variant for the access-om2
SPD. Don't mind either way, but not sure what that would entail.
!bump major
:white_check_mark: Version bumped from 2023.11.23
to 2024.03.0
:white_check_mark:
Bumped the major version because bitwise restart reproducibility represents a significant change in functionality.
We're going to need to push a new spack-packages
version to pick up the updated mom5
SPD right @CodeGat?
https://github.com/ACCESS-NRI/spack-packages/commit/203abecccd8426130b354c24b8b54d8604387dcd
Edit: and then we'll need to change the version in config:
https://github.com/ACCESS-NRI/ACCESS-OM2/blob/main/config/versions.json#L3
The Ci is failing because it's not comparing the versions correctly. Haven't dealt with the case as seen here: https://github.com/ACCESS-NRI/ACCESS-OM2/pull/54/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851abR13
This will require an update to the CI to fix, but I'll go through the packages.yml
syntax. Also with regards to
We're going to need to push a new spack-packages version to pick up the updated mom5 SPD right @CodeGat?
Yes, we will need to. Not only that, we will need to update the version of spack-config
in the versions.json
as the current one is using spack-start.bash
rather than spack-enable.bash
@aidanheerdegen
No longer required as +restart_repro
was made default for mom5
Add +restart_repro variant for mom5
Closes #53