search

ACCESS-NRI / ACCESS-OM2

ACCESS-OM2: ACCESS Ocean-Sea Ice Model
Apache License 2.0
5 stars 0 forks source link

Consider Prereleases to use `MODEL-PR#-BUILD` rather than `MODEL-VERSION-BUILD` #56

Closed CodeGat closed 3 months ago

CodeGat commented 3 months ago

Currently, we use MODEL-VERSION-BUILD (for example, access-om2-2024_03_0-2 where MODEL=access-om2, VERSION=2024_03_0, BUILD=2) to disambiguate our prerelease environments. During the skillshare, there was a suggestion that instead of VERSION we should use the PR number instead. This would allow a direct connection to a pull request (which is for now the only way we can prerelease). This could look something like MODEL-PR#-BUILD (access-om2-pr2-1 or access-om2-2-1).

aidanheerdegen commented 3 months ago

This means a pre-release environment can be deployed without requiring a valid version.

That could de-couple the version logic from the PR and shift the version checks to something that is only required before merging.

CodeGat commented 3 months ago

Can't believe I didn't think of it before! It's a useful change.