search

ACCESS-NRI / ACCESS-OM2

ACCESS-OM2: ACCESS Ocean-Sea Ice Model
Apache License 2.0
5 stars 0 forks source link

Spack environment installs the wrong MOM5 executable #71

Closed dougiesquire closed 1 month ago

dougiesquire commented 1 month ago

I think a recent change to the mom5 spd has changed the default variant type from "ACCESS-OM" to "ACCESS-CM". This breaks the ACCESS-OM2 release environment (e.g. it produces an fms_ACCESS-CM.x executable, not fms_ACCESS-OM.x).

$ git clone https://github.com/ACCESS-NRI/ACCESS-OM2.git
$ cd ACCESS-OM2/
$ spack env activate .
$ spack concretize -f
==> Concretized access-om2@git.2024.03.0=2024.03.0
 -   55lxyub  access-om2@git.2024.03.0=2024.03.0%intel@19.0.5.281~deterministic build_system=bundle arch=linux-rocky8-x86_64_v4
 -   nk6mqiy      ^cice5@git.2023.10.19=2023.10.19%intel@19.0.5.281~deterministic~optimisation_report build_system=makefile arch=linux-rocky8-x86_64_v4
 -   oy47sjo          ^datetime-fortran@1.7.0%intel@19.0.5.281 build_system=autotools patches=80b9577 arch=linux-rocky8-x86_64_v4
 -   ggoluv3          ^gmake@4.4.1%intel@19.0.5.281~guile build_system=generic arch=linux-rocky8-x86_64_v4
 -   lzrdczi          ^netcdf-c@4.7.4%intel@19.0.5.281~blosc~byterange~dap~fsync~hdf4~jna+mpi~nczarr_zip+optimize~parallel-netcdf+pic+shared~szip~zstd build_system=autotools arch=linux-rocky8-x86_64_v4
 -   45zs6fv              ^hdf5@1.14.3%intel@19.0.5.281~cxx~fortran+hl~ipo~java~map+mpi+shared~szip~threadsafe+tools api=default build_system=cmake build_type=Release generator=make arch=linux-rocky8-x86_64_v4
 -   jugwcxh                  ^zlib-ng@2.1.4%intel@19.0.5.281+compat+opt build_system=autotools arch=linux-rocky8-x86_64_v4
 -   g3tf2ue          ^netcdf-fortran@4.5.2%intel@19.0.5.281~doc+pic+shared build_system=autotools patches=b050dbd arch=linux-rocky8-x86_64_v4
 -   wpnvvxx          ^oasis3-mct@git.2023.11.09=2023.11.09%intel@19.0.5.281~deterministic~optimisation_report build_system=makefile arch=linux-rocky8-x86_64_v4
[e]  skdxayc          ^openmpi@4.0.2%intel@19.0.5.281~atomics~cuda~cxx~cxx_exceptions~gpfs~internal-hwloc~internal-pmix~java~legacylaunchers~lustre~memchecker~openshmem~orterunprefix+romio+rsh~singularity+static+vt+wrapper-rpath build_system=autotools fabrics=none patches=073477a,60ce20b schedulers=none arch=linux-rocky8-x86_64_v4
 -   ylrx5so          ^parallelio@2.5.2%intel@19.0.5.281+fortran~ipo~logging+mpi~pnetcdf~shared~timing build_system=cmake build_type=Release generator=make patches=55a6d7a arch=linux-rocky8-x86_64_v4
 -   yaxgpz5      ^libaccessom2@git.2023.10.26=2023.10.26%intel@19.0.5.281~deterministic~ipo~optimisation_report build_system=cmake build_type=Release generator=make arch=linux-rocky8-x86_64_v4
[e]  hebi6pz          ^cmake@3.24.2%intel@19.0.5.281~doc+ncurses+ownlibs build_system=generic build_type=Release arch=linux-rocky8-x86_64_v4
 -   dlmgtab          ^json-fortran@8.3.0%intel@19.0.5.281~ipo build_system=cmake build_type=Release generator=make arch=linux-rocky8-x86_64_v4
 -   3f2l3qw          ^pkgconf@1.9.5%intel@19.0.5.281 build_system=autotools arch=linux-rocky8-x86_64_v4
 -   epvxq43      ^mom5@git.2023.11.09=2023.11.09%intel@19.0.5.281~deterministic~optimisation_report+restart_repro build_system=makefile type=ACCESS-CM arch=linux-rocky8-x86_64_v4

See the type in the mom5 spec on the final line

aidanheerdegen commented 1 month ago

@harshula can you confirm this is closed by https://github.com/ACCESS-NRI/spack-packages/pull/116?

harshula commented 1 month ago

Hi @aidanheerdegen, The related Issue https://github.com/ACCESS-NRI/spack-packages/issues/115 is closed. I think you already verified that this Issue is fixed: https://github.com/ACCESS-NRI/ACCESS-OM2/pull/67/commits/5f4b36c6d708277f0596dcbc2d93fdbe23d13d64#diff-bd017515eb79a7fb7569b1d15e8963ea380123d4fdf779978dd4b3ab7500fd10R132 .