ACCESS-NRI / ACCESS-Vis

Visualisation examples and resources, including open-source 3D vis for ACCESS-NRI releases
Apache License 2.0
1 stars 0 forks source link

Additional frames required or end of videos are cut off #18

Closed OKaluza closed 3 weeks ago

OKaluza commented 3 weeks ago

There is a problem in the LavaVu video encoder that requires writing the additional frames at the end of the video or the last few seconds are cut off, I think this has been fixed in https://github.com/lavavu/LavaVu/commit/c7c4df6b6042a3d062397c708526ebc0d0dcf2d2 but needs to be tested and confirmed with the ACCESS-Vis example notebooks. If it is fixed, the final loop in the video encoding examples that write 30 extra frames can be removed

rbeucher commented 3 weeks ago

Have you updated the code on Pypi / conda?

OKaluza commented 3 weeks ago

It's fixed but not yet released, I'll do a LavaVu release now

rbeucher commented 3 weeks ago

Thanks. Let me know

OKaluza commented 3 weeks ago

This is confirmed fixed already but the other video player url issue took up all my time, it is in the latest release now.