search

ACCESS-NRI / access-esm1.5-configs

Standard ACCESS-ESM1.5 configurations released and supported by ACCESS-NRI
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

Remove unused inputs #13

Open aidanheerdegen opened 1 month ago

aidanheerdegen commented 1 month ago

It appears the geothermal heating isn't turned on

https://github.com/ACCESS-NRI/access-esm1.5-configs/blob/pre-industrial/ocean/input.nml#L53

Should we remove the geothermal_heating.nc input file?

aidanheerdegen commented 1 month ago

Also basin_mask.nc isn't a model input and was deleted from the OM2 1 degree configurations

https://github.com/COSIMA/access-om2/issues/205

Edit: to be explicit, this is an input file, but it isn't used

https://github.com/mom-ocean/MOM5/blob/d7ba13a3f364ce130b6ad0ba813f01832cada7a2/src/mom5/ocean_core/ocean_thickness.F90#L567-L571

https://github.com/ACCESS-NRI/access-esm1.5-configs/blob/pre-industrial/ocean/input.nml#L469

aidanheerdegen commented 1 month ago

CABLE-AUX-1.4/core/biogeochem/pftlookup_csiro_v16_17tiles.csv is commented out for the historical configuration:

https://github.com/ACCESS-NRI/access-esm1.5-configs/blob/pre-industrial/atmosphere/cable.nml#L56

aidanheerdegen commented 1 month ago

pftlookup_csiro_v16_17tiles_spinup.csv isn't referenced at all. Neither is poolcnpInTumbarumba.csv

aidanheerdegen commented 1 month ago

cf_name_table.txt seems superfluous. As does SOURCES which just contains a bunch of paths.

aidanheerdegen commented 2 weeks ago

We need some input from @MartinDix or Tilo on the CABLE inputs (or @ccarouge?).

@dougiesquire can you confirm I'm correct about the geothermal heating and basin mask

dougiesquire commented 2 weeks ago

@dougiesquire can you confirm I'm correct about the https://github.com/ACCESS-NRI/access-esm1.5-configs/issues/13#issue-2301838946 and https://github.com/ACCESS-NRI/access-esm1.5-configs/issues/13#issuecomment-2116650294

Yup, looks right to me (for the pre-industrial config at least)

ccarouge commented 2 weeks ago

@aidanheerdegen What do you mean by removing the input files? I guess I don't know what is happening around the ESM1.5 preparations so it's not clear what you mean.

For the pftlookup file, the namelist file points to a different file, CABLE only uses 1 of these files per configuration so it's ok to remove other pftlookup files.

For the pool file, I'm surprised there isn't a pool file specified in the CABLE namelist but that's reaching parts of CABLE I don't know much about. That said, the file you list poolcnpInTumbarumba.csv seems to be for a single point simulation (I don't know where this file is so I can't check) that isn't suitable for a global simulation so should be fine to remove. We'll see if @MartinDix knows better than me.

aidanheerdegen commented 2 weeks ago

What do you mean by removing the input files? I guess I don't know what is happening around the ESM1.5 preparations so it's not clear what you mean.

There appears to be a number of input files that just aren't used by the model configuration. So we would like to not include them in the input directory (remove them)

dougiesquire commented 2 weeks ago

I was surprised/curious about all the ocean/biogeochemistry inputs so I had a deeper look:

So...

If we only want to keep inputs that are used by the configuration without modification:

or, if we want to support users changing the WOMBAT field_table flags use_access_co2, gasx_from_file and ice_file4gasx:

(Note, someone who knows about these inputs should check all of this)

blimlim commented 3 days ago

I've had a go at removing the extra inputs from an esm1.5 configuration – most of the files could be removed without any issues, apart from:

The model crashes when either of these are removed even though the related namelist settings are .false.. Changing both files' values to zero doesn't seem impact the simulation at all, so it looks like the model is just trying to read in their values without using them.

I'm wondering what a good way to categorise these files in the restructured input directories be would be. E.g. do you think it would it be more confusing to classify them as unused but still require them in the config.yaml file, or to instead include them with the other required files despite them being ignored in the config's namelist settings? Or if there are any other ideas that could be good too!

aidanheerdegen commented 3 days ago

The model crashes when either of these are removed even though the related namelist settings are .false..

The version of csiro_bgc.F90 in the ACCESS-ESM1.5 fork doesn't do the check for gas_from_file before trying to open the file.

https://github.com/ACCESS-NRI/MOM5/blob/access-esm1.5/src/mom5/ocean_csiro_bgc/csiro_bgc.F90#L2027-L2029

Arguably then this should be back-ported to the ESM1.5 branch.

If it is just this commit then it may be straightforward to cherry-pick it

https://github.com/ACCESS-NRI/MOM5/commit/3f7b6de237d0872c55c557d6dcb16063c4ec355d

But I'll leave that up to @dougiesquire to make that call.

dougiesquire commented 1 day ago

If it is just this commit then it may be straightforward to cherry-pick it

https://github.com/ACCESS-NRI/MOM5/commit/3f7b6de237d0872c55c557d6dcb16063c4ec355d

But I'll leave that up to @dougiesquire to make that call.

I agree. PR here

dougiesquire commented 1 day ago

I agree. PR here

@blimlim, this PR has now been merged into the access-esm1.5 branch. When you get a chance, could you confirm that with this change you can now run without ocmip2_xkw_monthly_om1p5_bc.nc and ocmip2_fice_monthly_om1p5_bc.nc?

blimlim commented 20 hours ago

When you get a chance, could you confirm that with this change you can now run without ocmip2_xkw_monthly_om1p5_bc.nc and ocmip2_fice_monthly_om1p5_bc.nc?

Can do! I've added an issue to the ESM1.5 repository to incorporate these changes into a new MOM5 executable, and will test this out once its is ready. @penguian mentioned that it would be useful to set up automated issues in https://github.com/ACCESS-NRI/ACCESS-ESM1.5/ that are automatically created whenever there are new commits to the esm1.5 components.