codecov[bot]
commented
8 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
61784fb) 97.18% compared to head (856247d) 97.20%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== + Coverage 97.18% 97.20% +0.01% ========================================== Files 9 9 Lines 569 573 +4 ========================================== + Hits 553 557 +4 Misses 16 16 ``` | [Files](https://app.codecov.io/gh/ACCESS-NRI/access-nri-intake-catalog/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACCESS-NRI) | Coverage Δ | | |---|---|---| | [src/access\_nri\_intake/cli.py](https://app.codecov.io/gh/ACCESS-NRI/access-nri-intake-catalog/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACCESS-NRI#diff-c3JjL2FjY2Vzc19ucmlfaW50YWtlL2NsaS5weQ==) | `95.53% <100.00%> (+0.04%)` | :arrow_up: | | [src/access\_nri\_intake/catalog/manager.py](https://app.codecov.io/gh/ACCESS-NRI/access-nri-intake-catalog/pull/129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ACCESS-NRI#diff-c3JjL2FjY2Vzc19ucmlfaW50YWtlL2NhdGFsb2cvbWFuYWdlci5weQ==) | `98.30% <93.33%> (+0.09%)` | :arrow_up: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The
CatalogManagerclass is clunky and has some out-of-date docstrings. This PR reorganises the class a little to try and make it clearer and capable of loading different types of intake data source. Main changes:addmethod is no longer public. Entries are added to the catalog at the end of thebuild_esmorloadmethods.loadmethod now supports adriverargument for loading different types of intake data sourceCloses #128