ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue
https://access-nri-intake-catalog.rtfd.io
Apache License 2.0
8 stars 1 forks source link

The frequency in the intake catalog does not account for snapshot data #188

Open minghangli-uni opened 2 months ago

minghangli-uni commented 2 months ago

Is your feature request related to a problem? Please describe.

Snapshot diagnostics lack the time_bnds variable, causing the start_date and end_date from the intake-esm datastore to be incorrect.

One example is shown below, with the restart file access-om3.mom6.r.1915-01-01-00000.nc, where the output frequency is 2 hours and the total runlength is 30 hours, the start_date shows as 1915-01-01, 01:00:00 and the end_date is 1915-01-02, 07:00:00, instead of 1915-01-01, 00:00:00 and 1915-01-02 06:00:00.

path realm variable frequency start_date end_date
xx ocean xx 2hr 1915-01-01, 01:00:00 1915-01-02, 07:00:00

Describe the feature you'd like

Properly parse the date info such as, path realm variable frequency start_date end_date
xx ocean xx 2hr 1915-01-01, 00:00:00 1915-01-02, 06:00:00
marc-white commented 2 months ago

@minghangli-uni could you provide the location of that file so I can have a play with it?

dougiesquire commented 2 months ago

I stupidly didn't think about snapshot data when writing get_timeinfo. There's some logic in there to try and guess the start and end dates when time bounds are not present, but I realise now that this will produce incorrect start and end dates for snapshot data. I guess this logic should probably just be removed (i.e. remove this), though that will mean the start and end dates will be wrong for non-snapshot output that doesn't provided time bounds...

marc-white commented 3 weeks ago

@minghangli-uni could you please point me towards the catalog this file is a part of?

minghangli-uni commented 3 weeks ago

Hi @marc-white, I generated those files myself. You can find those at /scratch/tm70/ml0072/access-om3/archive/expt14-perturb-1052c5ae/output003 for your reference.