Closed marc-white closed 2 months ago
Attention: Patch coverage is 87.50000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.95%. Comparing base (
a07470a
) to head (bf43d6d
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/access_nri_intake/cli.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Let me know when you want another review @marc-white
This PR closes #185 by incorporating the schema descriptions (JSON) into the package. This has been done IAW what I think is current best practice for storing & loading data files within a package (https://docs.python.org/3/library/importlib.resources.html#module-importlib.resources).
Whilst doing this, I found a couple of places where the
data
submodule was doing some ad-hoc local data loads. These have also been updated to use the new pattern.Open questions: