ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue
https://access-nri-intake-catalog.rtfd.io
Apache License 2.0
8 stars 1 forks source link

199 data request 20km regional projections for cordex cmip6 queensland future climate science #219

Closed charles-turner-1 closed 1 month ago

charles-turner-1 commented 1 month ago

@marc-white You added config/experiments/cmip6_ig45.yaml in this branch - I've separately added a config/metadata_sources/cordex_ig45.yaml which is doing largely the same thing but seemed to follow the other source conventions more closely. Are you able to confirm whether there's a convention I'm unaware of?

Closes #199

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (d66ff09) to head (35c20fb). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/access_nri_intake/catalog/translators.py 98.38% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #219 +/- ## ========================================== - Coverage 97.00% 96.92% -0.09% ========================================== Files 9 9 Lines 635 650 +15 ========================================== + Hits 616 630 +14 - Misses 19 20 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charles-turner-1 commented 1 month ago

Yup - the changes to cmip6.yaml seem to go with the draft metadata.yaml you added. The cordex experiments needed a different translator, so I've separated them out - just hadn't cleaned up that file - everything should be sensible now.

I'm not 100% sure I understand the discussion around YAML paths fully - either that or it appears we need to update a bunch of paths in config/*.yaml?

marc-white commented 1 month ago

@charles-turner-1 There's a few things about YAML paths:

charles-turner-1 commented 1 month ago

@rbeucher my bad, moved it out of draft now.