Closed charles-turner-1 closed 1 month ago
Attention: Patch coverage is 98.38710%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 96.92%. Comparing base (
d66ff09
) to head (35c20fb
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/access_nri_intake/catalog/translators.py | 98.38% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yup - the changes to cmip6.yaml
seem to go with the draft metadata.yaml
you added. The cordex experiments needed a different translator, so I've separated them out - just hadn't cleaned up that file - everything should be sensible now.
I'm not 100% sure I understand the discussion around YAML paths fully - either that or it appears we need to update a bunch of paths in config/*.yaml
?
@charles-turner-1 There's a few things about YAML paths:
metadata.yaml
lives with the data. However, there are some "historical" experiments for which we don't have write access to their data area, so we have to store the metadata.yaml
within our own xp65
project. Where in xp65
was debated, given there is also an access-nri-intake-catalog
checkout in there somewhere we don't want to fiddle with/be dependent on in production.xp65
, but it accidentally got deleted. That's why we're holding all the metadata for the live catalog in a single place (/g/data/xp65/admin/intake/metadata
) to try and stop that happening again.metadata.yaml
s within the access-nri-intake-catalog
repository. This isn't for production use; it's just for reference in case the above problem happens again (and I guess might be handy for testing too, now that I think about it).@rbeucher my bad, moved it out of draft now.
Added Cordex CMIP6 Translators
Beginning refactoring @rbeucher noted would be useful in #211. There's a little more work to do here so I've left this as a draft PR for now.
@marc-white You added
config/experiments/cmip6_ig45.yaml
in this branch - I've separately added aconfig/metadata_sources/cordex_ig45.yaml
which is doing largely the same thing but seemed to follow the other source conventions more closely. Are you able to confirm whether there's a convention I'm unaware of?Closes #199