214 era 5 data request - Githubissues

ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue

https://access-nri-intake-catalog.rtfd.io

Apache License 2.0

8 stars 1 forks source link

214 era 5 data request #225

Closed charles-turner-1 closed 3 weeks ago

charles-turner-1 commented 1 month ago

Added ERA5 Translator & tests for translated data.
Moved test for 'tuplify_series' decorator to a more sensible spot in test_translators.py

Note

Still a bunch of additional commits in here relating to #212 as this branch was opened before we finished merging that so we'll need to be careful to clean those out in the squashed commit message.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.46%. Comparing base (77538ef) to head (e4abe87). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #225 +/- ## ========================================== + Coverage 96.36% 96.46% +0.09% ========================================== Files 9 9 Lines 688 707 +19 ========================================== + Hits 663 682 +19 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charles-turner-1 commented 3 weeks ago

@rbeucher are you able to review?

rbeucher commented 3 weeks ago

Yes I will

charles-turner-1 commented 3 weeks ago

Looks good to me! I noticed some discrepancies where certain PRs point to /g/data/xp65/admin/intake and others to /g/data/xp65/admin/access-nri-intake-catalog. We’ll need to double-check these paths before the release.

Sounds good - I'll add a note to #230.

charles-turner-1 commented 3 weeks ago

Closes #214