search

ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue
https://access-nri-intake-catalog.rtfd.io
Apache License 2.0
8 stars 1 forks source link

Remove EraiTranslator and erai catalogs #236

Closed marc-white closed 3 weeks ago

marc-white commented 3 weeks ago

Closes #224 .

The ERA catalogues on hh5 will disappear going forward. As the erai.yaml catalog file was already being excluded from the catalog build process, it was decided it was time to remove it completely, as well as the related Translator (noting the catalogs were pre-built, so there is no associated Builder).

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.44%. Comparing base (204518a) to head (6aed4b8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 96.46% 96.44% -0.03% ========================================== Files 9 9 Lines 707 703 -4 ========================================== - Hits 682 678 -4 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marc-white commented 3 weeks ago

Good catch @charles-turner-1 , data removed.

charles-turner-1 commented 3 weeks ago

Looks like I can't approve @rbeucher's requested changes - all looks good to me though.

marc-white commented 3 weeks ago

I think @rbeucher is required to tick that his requested changes have been made. Look at us discovering new GitHub functionality!

dougiesquire commented 3 weeks ago

@charles-turner-1 I've made you admin on this repo. @marc-white, you were already admin.