ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue

https://access-nri-intake-catalog.rtfd.io

Apache License 2.0

8 stars 1 forks source link

223-model-required #255

Closed charles-turner-1 closed 4 days ago

charles-turner-1 commented 1 week ago

Changes

I fixed up a couple of tangentially related bits in the translators - looks like some WIP got accidentally merged in the @tuplify_series decorator & moved that to a separate file.
Added more thorough error handling, checking for specific data issues & pointing to #223 is it appears to be related.
Tests for error handling.
- The tests use mock raises - I'd really rather avoid this if possible & pass data broken in the specific expected ways, but it was sinking too much time so I'll raise it as a new issue & come back to check.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.10%. Comparing base (6d9bf87) to head (d506b22). Report is 7 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #255 +/- ## ========================================== + Coverage 97.75% 98.10% +0.34% ========================================== Files 10 11 +1 Lines 803 843 +40 ========================================== + Hits 785 827 +42 + Misses 18 16 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charles-turner-1 commented 1 week ago

Will require intake-dataframe-catalog too in order to work properly.

rbeucher commented 1 week ago

Should we try to fix the coverage?

charles-turner-1 commented 1 week ago

Yeah, it's just a straightforward catch all that needs an additional test - should take 5 minutes, I'll do it first thing Monday.