search

ACCESS-NRI / access-nri-intake-catalog

Tools and configuration info used to manage ACCESS-NRI's intake catalogue
https://access-nri-intake-catalog.rtfd.io
Apache License 2.0
8 stars 1 forks source link

Add MOM6 support (om4 025jra ryf) #258

Open marc-white opened 1 week ago

marc-white commented 1 week ago

Closes #175 .

This PR adds the data requested from #175 , which required a new builder: MOM6Builder.

PR includes relevant builder, translator, and tests.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.37%. Comparing base (4fb9856) to head (101c948).

Files with missing lines Patch % Lines
src/access_nri_intake/source/builders.py 86.95% 3 Missing :warning:
src/access_nri_intake/catalog/manager.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #258 +/- ## ========================================== - Coverage 97.90% 97.37% -0.54% ========================================== Files 11 11 Lines 811 837 +26 ========================================== + Hits 794 815 +21 - Misses 17 22 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charles-turner-1 commented 1 week ago

All tests passing - just codecov that's not passing.

I guess that must mean that CI environment isn't mirroring Gadi correctly..

rbeucher commented 23 minutes ago

I agree with @charles-turner-1. Would be good to fix codecov and pre-commit though.