codecov[bot]
commented
1 year ago Codecov Report
Merging #91 (26a0b6b) into main (d83c8bb) will increase coverage by
2.95%. The diff coverage is42.85%.
@@ Coverage Diff @@
## main #91 +/- ##
=========================================
+ Coverage 8.61% 11.56% +2.95%
=========================================
Files 10 10
Lines 511 519 +8
=========================================
+ Hits 44 60 +16
+ Misses 467 459 -8 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/access_nri_intake/source/builders.py | 0.00% <0.00%> (ø) |
|
| src/access_nri_intake/source/utils.py | 36.47% <46.15%> (+1.58%) |
:arrow_up: |
This PR includes a new implementation of the approach for getting file ids from filenames. Explicit regex patterns corresponding to known ACCESS output filenames are now matched to generate a file id (by redacting time stamps and replacing non-python characters) and extract any time information contained in the filename. This approach to generating the file id is probably more robust than the old approach (see #67). Additionally, the time information extracted is used in conjunction with the output of
get_timeinfoto make it more robust (see #20) and could also be useful elsewhere (e.g. see #62)