search

ACCESS-NRI / access-om3-configs

ACCESS-OM3 MOM6-CICE6 configurations
1 stars 8 forks source link

fix JRA55do runoff remapping bug #113

Closed aekiss closed 1 month ago

aekiss commented 2 months ago

closes https://github.com/COSIMA/access-om3/issues/208

aekiss commented 2 months ago

this will need to be cherry-picked into all other configs

anton-seaice commented 2 months ago

I guess we need the same change to https://github.com/COSIMA/om3-scripts/blob/main/data_stream_xml_generation/generate_xml_datm.py ?

aekiss commented 2 months ago

Ah yes, good point! @ezhilsabareesh8 do you have a spare moment to do that?

dougiesquire commented 2 months ago

Sorry to be a pain in the arse, but I don't think we want to get in the habit of making changes without updating the manifest. I understand they can make cherry-picking difficult, but they're an important part of the provenance.

aekiss commented 2 months ago

Agreed @dougiesquire, I'd forgotten these files were script-generated so we should re-generate them (and while we're at it, fix https://github.com/COSIMA/om3-scripts/issues/27 and https://github.com/COSIMA/om3-scripts/issues/29).

Re. manifests, I think we should have one commit containing only the manifest changes, and another containing everything else. That way we can just cherry-pick the 2nd commit.

dougiesquire commented 2 months ago

Agreed @dougiesquire, I'd forgotten these files were script-generated so we should re-generate them (and while we're at it, fix https://github.com/COSIMA/om3-scripts/issues/27 and https://github.com/COSIMA/om3-scripts/issues/29).

Sorry, I was rushing and I merged https://github.com/COSIMA/om3-scripts/pull/28 before seeing your new om3-scripts issues. I agree we should fix these both. @ezhilsabareesh8 could you please make these changes?

Re. manifests, I think we should have one commit containing only the manifest changes, and another containing everything else. That way we can just cherry-pick the 2nd commit.

Sounds good to me

dougiesquire commented 2 months ago

@aekiss, om3-scripts has now been updated to fix the above issues (thanks to @ezhilsabareesh8). I've updated the version of om3-scripts at /g/data/vk83/apps/om3-scripts, so you could use that to generate the new stream files.

aekiss commented 2 months ago

Thanks @dougiesquire, I'm happy for somebody else to do that if you're waiting on it - I'm busy in a workshop tomorrow so might struggle to get to it.

aekiss commented 2 months ago

thanks Dougie

aekiss commented 1 month ago

Closing - PR replaced by https://github.com/ACCESS-NRI/access-om3-configs/pull/123