search

ACCESS-NRI / access-om3-wav-configs

ACCESS-OM3 MOM6-CICE6-WW3 configurations
0 stars 1 forks source link

Restructure input directory #12

Closed micaeljtoliveira closed 11 months ago

micaeljtoliveira commented 11 months ago

Closes #8

dougiesquire commented 11 months ago

Annoying that manifests are including everything in /g/data/ik11/inputs/JRA-55/RYF/v1-4/make_rhuss/.git though...

Should the make_rhuss and make_ryf directories be moved? They aren't actually inputs

micaeljtoliveira commented 11 months ago

Should the make_rhuss and make_ryf directories be moved? They aren't actually inputs

I think we should move them if possible. Otherwise, maybe Payu should simply ignore hidden directory and files. I can't really see a legitimate use case for someone to use a hidden input file or directory, but maybe I'm wrong...

dougiesquire commented 11 months ago

Otherwise, maybe Payu should simply ignore hidden directory and files

Yeah, I thought about this too, but I think moving them makes sense since there's no reason for anything in those directories to copied as inputs and added to the manifest. If we're worried about provenance, we could modify the Python scripts in those directories to also add the git commit hash to the metadata of the files they create.

micaeljtoliveira commented 11 months ago

but I think moving them makes sense since there's no reason for anything in those directories to copied as inputs and added to the manifest.

I agree, but the two things are not exclusive. Let's raise the question with Aidan and see what he thinks.

In the meantime, shall we merge this or wait for this to be resolved?

dougiesquire commented 11 months ago

Let's raise the question with Aidan and see what he thinks.

Sure

In the meantime, shall we merge this or wait for this to be resolved?

If @aekiss is okay with moving the directories, my vote is for doing that now, but I don't feel strongly

aekiss commented 11 months ago

I'm happy for this PR to be merged. We can worry about those directories some other time (maybe make an issue so we don't forget)