search

ACCESS-NRI / access-om3-wav-configs

ACCESS-OM3 MOM6-CICE6-WW3 configurations
0 stars 1 forks source link

Updated WW3's Configuration: Move Variables from ww3_shel.nml to wav_in #23

Closed ezhilsabareesh8 closed 4 months ago

ezhilsabareesh8 commented 5 months ago

This PR addresses issue #143 which is about the recent update in WW3's wav_shel_inp.F90 codebase. The ww3_shel.nml file is no longer utilised and in this PR all variables stored in ww3_shel.nml are moved to the wav_in file for proper functionality of the configuration.

anton-seaice commented 5 months ago

Are all the variables used?

Like there was this cryptic note:

! Note that CESM restarts are not controlled by namelist input ! - but rather by driver config variables which I guess applies to the 'domain' lines and implies they are not used?

ezhilsabareesh8 commented 4 months ago

which I guess applies to the 'domain' lines and implies they are not used?

Thanks Anton, Yes, only the domain_nml is not used, I have removed those in this commit ffa0f0d

ezhilsabareesh8 commented 4 months ago

It looks like we forgot to do #15 for the iaf branch?

I have changed the WW3 inputs, only ice_in needs to be updated. We merge this and handle in separate PR or would you like do it in this PR?

anton-seaice commented 4 months ago

In a seperate PR :)

anton-seaice commented 4 months ago

I will do #15 for this repo now too