rdump/sdump code uses uninitialised OASIS_CNTLPE variable

[penguian]

resolution_fixed | by mrd599@nci.org.au

---

The routines that save the diagnostic coupling fields all have a check near the start

   IF (LMYPE .NE. OASIS_CNTLPE) RETURN

However the OASIS_CNTLPE variable is a left-over from the OASIS3 code and isn't initialised in vn10.6 and so the comparison fails and the diagnostic files aren't written.

---

Issue migrated from trac:322 at 2024-01-31 18:29:42 +1100

[penguian]

@martin.dix@anu.edu.au changed status from new to accepted

[penguian]

@martin.dix@anu.edu.au set owner to mrd599

[penguian]

@martin.dix@anu.edu.au commented

---

The only non-diagnostic use is in checks like

  IF ((l_couple_master .AND. mype == oasis_cntlpe) .OR.            &
      (.NOT. l_couple_master)) THEN

which aren't affected because we use l_couple_master=.false.

The initialisation of OASIS_CNTLPE was removed back in vn8.4. The variable is finally removed completely (along with l_couple_master) by https://code.metoffice.gov.uk/trac/um/ticket/2524.

Fix is to change the rdump/sdump routines to simply check

   IF (MYPE /= 0) RETURN

[penguian]

@martin.dix@anu.edu.au changed status from accepted to closed

[penguian]

@martin.dix@anu.edu.au set resolution to fixed

[penguian]

@martin.dix@anu.edu.au commented

---

Fixed in https://code.metoffice.gov.uk/trac/um/changeset/40051/main/branches/dev/martindix/vn10.6_access_cm2