search

ACCESS-NRI / actions

Custom GitHub Actions for use across the ACCESS-NRI
0 stars 0 forks source link

Add comment action as an update of PR-comment one #12

Closed atteggiani closed 23 hours ago

atteggiani commented 1 week ago

Fixes #11.

A new action called comment was added to update functionality of the PR-comment action.

To better understand all the features, please read the README.

CodeGat commented 6 days ago

Just before I get into reviewing this update to the action, I was wondering if it'd be better suited as a different action, since it breaks backwards compatibility. Just so it would be a more staggered approach to moving to the new action. Also, the action name (pr-comment) now seems to be more restrictive...Could we have a new action just named comment, maybe?

atteggiani commented 6 days ago

Just before I get into reviewing this update to the action, I was wondering if it'd be better suited as a different action, since it breaks backwards compatibility. Just so it would be a more staggered approach to moving to the new action. Also, the action name (pr-comment) now seems to be more restrictive...Could we have a new action just named comment, maybe?

Yes it make sense. If you think it would be better to change name, then I would say we should set up a brand new action (I like the comment name). If naming is not a big issue, I would keep this one and back-compatibility could still be preserved by using the right ref (uses: access-nri/actions/.github/actions/pr-comment@4134cbeec8523173798a1bfacccd79c967e58022 would be the one already used at the moment)

CodeGat commented 5 days ago

I think it might be best to have your action be a different name (comment does sound more general) and then slowly port over from pr-comment to comment. I know that we can use the commit ref, but if we are eventually moving all of them over to comment it would mean that we need to do two modifications to the various bits of infrastructure that do comments...so I think the comment action is best.

atteggiani commented 5 days ago

I think it might be best to have your action be a different name (comment does sound more general) and then slowly port over from pr-comment to comment. I know that we can use the commit ref, but if we are eventually moving all of them over to comment it would mean that we need to do two modifications to the various bits of infrastructure that do comments...so I think the comment action is best.

Sure! I will move this to a new folder called comment then.

atteggiani commented 1 day ago

@CodeGat the suggested modifications have been applied. Instead of directly updating the existent pr-comment action, the new comment action was created.