search

ACCESS-NRI / cice4

CICE4 repository containing code uploaded from subversion repo
0 stars 0 forks source link

Fix syntax error in cice_runmod.F90 by removing continuation #6

Closed penguian closed 2 weeks ago

penguian commented 6 months ago

Closes #5 for the access-esm1.5 branch.

The code change has been tested by building the cice4 Spack package using the 5-syntax-error-in-cice_runmod-f90 branch instead of access-esm1.5, and the package builds successfully using both %intel@19.0.5.281 and %intel@2021.10.0.

penguian commented 6 months ago

The syntax error described in #5 also exists in other branches, such as main ( https://github.com/ACCESS-NRI/cice4/blob/main/drivers/access-cm/CICE_RunMod.F90 ) and a separate issue should be raised if necessary.

anton-seaice commented 4 months ago

The change looks good :)

Is the plan to keep the access-esm1.5 branch long term? Can we merge it with the main branch?

Why are we discovering this now? esm1.5 obviously already exists and can be built etc ...

penguian commented 3 weeks ago

@anton-seaice The released versions of ACCESS-ESM1.5 still use the access-esm1.5 version of CICE4. As far as I know the plan is to keep this branch for reproducibility purposes. @aidanheerdegen Is this correct?

Th reason why we are not hitting this problem all the time is that we are still using the 2019 version of the Intel Fortran compiler, and the issue was discovered when using the 2021 compiler. See issue #5

penguian commented 2 weeks ago

I signed the most recent commit on the local branch using

git commit --amend --no-edit -S

then force pushed the local branch using

git push origin 5-syntax-error-in-cice_runmod-f90 --force

The commits compare as identical: https://github.com/ACCESS-NRI/cice4/compare/3de3702cd27922cd77709d68075922a37302cbb6..a2ca8da8632632339501d5bf23124356d15ec70b