search

ACCESS-NRI / model-config-tests

Tests for checking model configurations
Apache License 2.0
0 stars 1 forks source link

`ACCESS-ESM1.5` `mppnccombine` MPI Test Fix #47

Closed CodeGat closed 1 month ago

CodeGat commented 1 month ago

See https://github.com/ACCESS-NRI/access-esm1.5-configs/pull/44/checks?check_run_id=28688143378

We allow collate.mpi to be either true or false, rather than only true.

Since converting the .yaml file into a Python dict also converts the above to a bool, test that the resulting value is an instance of bool.

In this PR:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (f2f37d9) to head (2d538a5). Report is 1 commits behind head on main.

Files Patch % Lines
...model_config_tests/qa/test_access_esm1p5_config.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ======================================= Coverage 73.48% 73.48% ======================================= Files 15 15 Lines 724 724 ======================================= Hits 532 532 Misses 192 192 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.