ACCESS-NRI / model-config-tests

Tests for checking model configurations
Apache License 2.0
0 stars 1 forks source link

Fix Successful Repro Pipeline Errors #56

Closed CodeGat closed 1 month ago

CodeGat commented 1 month ago

This PR fixes a couple of errors found when a config successfully reproduces, namely:

And fixes up some variables in comments:

Linking failed PRs https://github.com/ACCESS-NRI/access-esm1.5-configs/pull/86 and https://github.com/ACCESS-NRI/access-esm1.5-configs/pull/87 Closes #57

aidanheerdegen commented 1 month ago
  • The pipeline was allowing merging when the version hadn't been updated. This was because it was comparing release ('1.0') against dev (''), seeing that the versions were different, and allowing merging. We now check for '', not just null. See 89d6d6c and 6a36a4c.

Bugger. Now I remember we missed the step of merging the version from release back into dev.

Does the new logic mean we never have to do this? I don't think it's a good idea, so perhaps we should special case when the dev is null or empty but release has a version, and insist that the current version is added to dev?

CodeGat commented 1 month ago

I think that the solution is to have modified the version to 1.0 in the dev-* branch rather than the release-* branch. But then we'd still have to have added a boring commit to the trigger the on.push.paths=metadata.yaml anyway.

The real solution is to add another trigger to the version bumping stuff on the release-* branch: on.create, and check that it is a release-* branch.