ACCESS-NRI / reproducibility

Framework and tools for reproducibility testing of models
GNU General Public License v3.0
0 stars 0 forks source link

Added Reusable Workflow for Generating Initial Config Branch Checksums #10

Closed CodeGat closed 7 months ago

CodeGat commented 7 months ago

In this PR: * Added reusable generate-initial-checksums.yml workflow

References ACCESS-NRI/access-om2-configs#9

CodeGat commented 7 months ago

Yes that is true - I was wondering if maybe you'd have: config-branch-name: release-1deg_jra55_iaf target-branch-name: dev-1deg_jra55_iaf Or something. If there aren't any possible use cases, then I can simplify it. What do you think @aidanheerdegen ?

aidanheerdegen commented 7 months ago

Yes that is true - I was wondering if maybe you'd have: config-branch-name: release-1deg_jra55_iaf target-branch-name: dev-1deg_jra55_iaf Or something. If there aren't any possible use cases, then I can simplify it. What do you think @aidanheerdegen ?

I can see the programming logic, but if 90% of the use cases are covered by assuming config-branch-name == target-branch-name then it makes it a lot simpler, and maybe easier to understand, for the person using it to just specific a single branch.

The case for a committing to a different branch is also covered if target-branch is just branched from config-branch, e.g.

git checkout config-branch-name
git checkout -b target-branch-name
git push origin target-branch-name

and then run the simplified workflow on target-branch-name

CodeGat commented 7 months ago

Good point. I'll simplify.