ACCESS-NRI / spack-packages

Spack package repository maintained by ACCESS-NRI
Apache License 2.0
4 stars 4 forks source link

Move variants/compiler flags from `spack.yaml` to relevant `package.py`s #103

Closed CodeGat closed 2 months ago

CodeGat commented 2 months ago

See https://github.com/ACCESS-NRI/ACCESS-OM3/pull/5#issuecomment-2089614861 and spack.yaml in https://github.com/ACCESS-NRI/ACCESS-OM3/pull/5/files#diff-e8582e74fa156f4e5729a850e52b24f2fde2d815c2c9c360f88c4cf90db851ab

In this PR:

Closes #102

CodeGat commented 2 months ago

~Athough installing is having a problem with fmss +large_file variant...~ Might be an issue with the dev image I'm using

CodeGat commented 2 months ago

Very good to know that depends_on is composed like that. Thanks - ready for re-review.

CodeGat commented 2 months ago

Thanks for going through it with me! It'll make future package.py changes a bit less Changes Requested, I'm sure.