ACCESS-NRI / spack-packages

Spack package repository maintained by ACCESS-NRI
Apache License 2.0
4 stars 4 forks source link

Check um7 variants #113

Open penguian opened 1 month ago

penguian commented 1 month ago

In https://github.com/ACCESS-NRI/spack-packages/blob/main/packages/um7/package.py the following lines appear.

        env["openmp"] = boolstr("~omp" in spec)
        env["netcdf"] = boolstr("~netcdf" in spec)

These lines look strange because "~" in a Spack spec is used to turn a variant off. See https://spack.readthedocs.io/en/latest/basic_usage.html#variants

Check to see that these variants do what is expected, and correct package.py if necessary.