search

ACCESS-NRI / spack-packages

Spack package repository maintained by ACCESS-NRI
Apache License 2.0
4 stars 4 forks source link

Copy packages required for `OM3` from `COSIMA/spack_packages` #93

Closed CodeGat closed 2 months ago

CodeGat commented 2 months ago

In this PR:

References #91

micaeljtoliveira commented 2 months ago

Probably it would be good to submit the changes to the FMS package upstream.

harshula commented 2 months ago

There's an upstream version of fms at https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/fms/package.py

harshula commented 2 months ago

Hi @micaeljtoliveira , Do you use large_file and/or internal_file_nml variants?

harshula commented 2 months ago

Hi @CodeGat , Probably drop the copying of fms SPD. Spack v0.21 fms is only missing two variants and shouldn't impact your CI.

micaeljtoliveira commented 2 months ago

Hi @micaeljtoliveira , Do you use large_file and/or internal_file_nml variants?

Yes. Otherwise I wouldn't have bothered adding them ;)

Edit: if you don't add them, the model won't work correctly.

harshula commented 2 months ago

Hi @micaeljtoliveira , Can you please submit the patch upstream? They are default false in the SPD. Can you please elaborate how you use them? Are they default true in FMS' build system?

micaeljtoliveira commented 2 months ago

Hi @micaeljtoliveira , Can you please submit the patch upstream? They are default false in the SPD. Can you please elaborate how you use them? Are they default true in FMS' build system?

Yes, sure, I can submit upstream. +large_file is set explicitly in the environment definition. Looks like internal_file_nml is not set, but I'm afraid I don't remember exactly why. The only thing I'm quite sure is that both are set by in CESM, which was used as a template for OM3.