Closed MarinManuel closed 2 months ago
disregard the part about change the req for pandas. I don't know why my pandas version was stuck at 0.25.x in my test environment. I just realized that DABEST requires pandas v.1.1 now.
Further tests showed that my initial fix was not working. I suggest testing for str
, int
and float
idx. I'm sure there might be cases where that's not enough, but that probably covers most use cases?
The bug is solved.
Solved in PR #174.
I've noticed DABEST does not let me work with dataframes where column names are not strings.
example:
results in an Exception:
As far as I understand, any hashable can be used as a column name (an
Index
really). I'm not sure what use case there is for exotic types, but I often have columns that are named withint
orfloat
.I'm going to propose a fix, but I'm not entirely sure the solution is robust. I'm would test for
Hashable
instead ofstr
, but some iterables are hashables (frozensets, tuples, range) and I don't quite know how you'd deal with that.PLUS there is an independent but related bug in pandas that prevents the fix from working. See here. The bug was fixed in v.1.0.0 and DABEST would need to require that version to work properly.