ACCLAB / DABEST-python

Data Analysis with Bootstrapped ESTimation
https://acclab.github.io/DABEST-python/
Apache License 2.0
340 stars 47 forks source link

Add new swarmplot function #158

Closed sunroofgod closed 7 months ago

sunroofgod commented 8 months ago

NEW Features:


Bug Fixes:

sangyu commented 8 months ago

@sunroofgod nice code! I just tested it it works very well! since now this is going to be the default behaviour, please do the following:

  1. Update the test graphics so that pytests will pass.
  2. Add a section in 06-plotaesthetics.ipynb to demonstrate the use of the swarm-side argument. Alternatively, since the is such a departure from regular swarm plots, maybe it can be explained in 01-basics.ipynb
sunroofgod commented 8 months ago

Hi @sangyu, will do!

I've already previously updated the images for pytest. You can see the new images under the commit that says "updated baseline images..."

With regards to the tutorial updates, I'll update them and let you know once its been done :)

sangyu commented 8 months ago

oh my bad I missed the baseline images. nice thanks!

sunroofgod commented 8 months ago

hi, I realised maybe I should only be editting the tutorial docs once I've rebased this branch on top of the new Rosa changes (because Rosa made changes to the documentation docs too). So maybe I'll only be doing this once PR https://github.com/ACCLAB/DABEST-python/pull/157 has been merged?

Jacobluke- commented 8 months ago

PR #157 has been merged, you can proceed

sunroofgod commented 8 months ago

@sangyu I've added a section in 06-plotaesthetics.ipynb to demonstrate the use of the swarm_side argument. I also reran the notebooks to reflect the new changes for all the swarmplots & deltadots.

sangyu commented 8 months ago

nice thanks!