Fixed bug in inset axes

ACCLAB / DABEST-python

Data Analysis with Bootstrapped ESTimation

https://acclab.github.io/DABEST-python/

Apache License 2.0

341 stars 47 forks source link

Fixed bug in inset axes #74

Closed anekimken closed 5 years ago

anekimken commented 5 years ago

My code had a bug where the lines on the x axis of the estimation plot got drawn on every set of axes in the entire fig. Not a problem if all you have in the figure is the estimation plot, but still a problem if you have other.

josesho commented 5 years ago

I spotted the same bug as well; and earlier pushed the same fix as you!

So I'm gonna close this PR, but thanks for the attention to detail.

FYI, I'm going to do a little writeup about this in the docs, and also fix #72 before I push 0.2.6 to master, as well as release to PyPi.

PS I should also add a note somewhere about which branches to PR to—ideally it should be on the dev branch (which is currently 0.2.6, and which I need to mark as such...)

anekimken commented 5 years ago

Sounds good. This is actually the first time I’ve contributed to a package like this, so the dev branch might be more obvious for someone a bit more savvy.

josesho commented 5 years ago

I'm learning myself as well! This isn't on the scale of matplotlib or seaborn (and it shouldn't get there... God forbid!) but with more contributors like yourself we'll need a bit more scaffolding....