search

ACCarnall / bagpipes

Bagpipes is a state of the art code for generating realistic model galaxy spectra and fitting these to spectroscopic and photometric observations. Users should install with pip, not by cloning the repository.
http://bagpipes.readthedocs.io
GNU General Public License v3.0
81 stars 42 forks source link

Update dust_attenuation_model.py #81

Closed k-ormerod closed 4 months ago

k-ormerod commented 5 months ago

I have been fitting models with the Salim+2018 dust attenuation model, and I noticed when looking at how this was implemented that the width of the bump feature is input at 375A on the denominator.

I have updated this to 350A to be consistent across the implementation of the Drude profile and in line with the Salim+18 paper.

ACCarnall commented 4 months ago

Hi Katherine,

Thanks for bringing this up, I'll try to find time to look into it at some point soon.

Cheers, Adam

ACCarnall commented 4 months ago

Thanks for catching this Katherine, I've been back through the commit history and can't find an obvious reason, I guess it was just a very old typo!