Closed paolap closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Apologies, I just properly read your first comment @paolap. It's a good idea to get this merged to have a common base for everyone to start thinking about the restructure. Shall we address the comments in my review above, get this merged and then we can all think about reorganising from main
?
yes, that was the idea, this actually it doesn't have a lot of new additions compared to main.
1) the repetition is because a couple of these notebooks have been created as placeholders from computations. I kept some of the original text to have a reference on how to style them in a comparable way.
2) I removed the goals.md file as it is not used. They are indeed included in the introduction.
3) I fixed the typos you listed, these were some of the few new addition, but the overall tools part needs more reviews anyway
So if you're happy with it I pushed the fixes and I'll merge
I also made sure that the typos were fixed in restructure_paola in case so one starts from there, so they won't get lost :-)
This branch includes Dougie paragraph from this pull_request: https://github.com/ACDguide/BigData/pull/70 in the tools-python1 file instead of the intro.
I also resolved Claire comments, removed the VSCode comment and put Dougie text in a warning box.
I also merged the latest main (i.e. after this pull_request: https://github.com/ACDguide/BigData/pull/68 was merged)
Finally I checked that use of netCDF/NetCDF (capitalise at start of sentence/header) and Zarr was consistent and fixed it where necessary.
Nothing from this branch should generate a conflict, it should just allow us to have a clean slate before restructuring.