ACE-IoT-Solutions / ace-svg-react

Grafana SVG Rendering Panel using the 7+ Plugin Framework
https://grafana.com/grafana/plugins/aceiot-svg-panel/
MIT License
40 stars 14 forks source link

Grafana version 8 and ace-svg plugin does not play well #21

Closed ilayn closed 2 years ago

ilayn commented 3 years ago

Super thanks for this plugin which makes life extremely easy. We recently upgraded to Grafana 8 but it seems like there is some problems.

I didn't know how to start troubleshooting since the plugin never kicks in so I'm just giving a heads up about it.

tobehn commented 3 years ago

I just updated to Grafana 8. The Plug-in is not loading anymore. Instead it says Panel plugin not found: aceiot-svg-panel in the Panel.

Is this plugin compatible to Grafana 8 ? If not? What needs to be done and is there anything I can help with?

tobehn commented 2 years ago

The Plugin is unsigned: https://grafana.com/docs/grafana/latest/plugins/plugin-signatures/

Perhaps this ace-svg-react can be submitted for signing: https://grafana.com/docs/grafana/latest/developers/plugins/sign-a-plugin/

Meanwhile it can be allowed to load on startup by setting it in _allow_loading_unsignedplugin in grafana.ini: https://grafana.com/docs/grafana/latest/administration/configuration/#allow_loading_unsigned_plugins

acedrew commented 2 years ago

The latest version was meant to be signed, we'll take a look and get this resolved.

Thanks for the heads up.

On Mon, Jul 26, 2021 at 4:09 AM tobehn @.***> wrote:

The Plugin is unsigned: https://grafana.com/docs/grafana/latest/plugins/plugin-signatures/

Perhaps this ace-svg-react can be submitted for signing: https://grafana.com/docs/grafana/latest/developers/plugins/sign-a-plugin/

Meanwhile it can be allowed to load on startup by setting it in allow_loading_unsigned_plugin in grafana.ini:

https://grafana.com/docs/grafana/latest/administration/configuration/#allow_loading_unsigned_plugins

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ACE-IoT-Solutions/ace-svg-react/issues/21#issuecomment-886476124, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHOUBYETHMLR4JZZU3UAHLTZUJ2LANCNFSM5AIMVKMA .

tobehn commented 2 years ago

I am very sorry. I missed to update the plugin itself. Now i have the latest version and it states signed under plugins.

In the end i realized i had that problem due to an old version of the plugin (0.0.6) which might have not been install via grafana-cli. So i had both versions (0.0.6 and 0.0.10) in my plugins folder. Even though it stated signed in grafana plugins it seemed to load the older version of the plugin. After manually removing the old version and reinstalling the newest via CLI the loading problem was gone. Also if removed removed it from _allow_loading_unsignedplugins in grafana.ini.

ilayn commented 2 years ago

I can also confirm that we have a working instance of the plugin. I don't know the exact reason but our DevOps reinstantiated the plugins and things went back to normal. Sorry for the noise.

ghost commented 2 years ago

@tobehn was your issue a problem of a "Modified signature"?

I encountered a similar issue today and was wondering if the issues are related. Mine's listed as #22

tobehn commented 2 years ago

was your issue a problem of a "Modified signature"?

no, the plugin was marked "unsigned" in my case it happend due to a second instance of the plugin, that somehow made it into my plugin folder. When i installed the plugin via grafana-cli i got the latest published version. By having the two versions in the plugin folder grafana seemed to load the older version. At least the unsigned label was gone after i deleted the old version.