ACE-IoT-Solutions / ace-svg-react

Grafana SVG Rendering Panel using the 7+ Plugin Framework
https://grafana.com/grafana/plugins/aceiot-svg-panel/
MIT License
40 stars 14 forks source link

geomap draft #30

Open evannorton opened 2 years ago

evannorton commented 2 years ago

This is a draft PR for issue #25. What I have so far on this branch is a toggle button for displaying or hiding a geomap that renders on a background layer, with multiple copies of the svg rendered at specific coordinates, defined by geohashes. There are some problems though, and some may be caused by code not specific to this branch. When dynamically increasing/decreasing the amount of SVGs that are rendered by changing the data, sometimes a runtime error is thrown in the console from react source. This has proved very difficult to debug and I think it may be valuable to update react to the latest version and possibly make a switch to functional components before debugging further. I also recall running into cases where the SVGs were not animating properly, which I believe is not specific to this branch and could be related to #29 and/or #23. I did experience some cases where my browser tab has crashed while working on this branch as well which I am unsure what the cause is or if it is specific to this branch. The main planned features that are missing from this branch are exposing SVG data so it can be accessed in the user generated code, and implementing camera movement so that marked points on the geomap are zoomed toward initially.