search

ACED-IDP / aced-idp.github.io

Documentation Site for the ACED Data Commons
https://aced-idp.github.io/
Apache License 2.0
1 stars 0 forks source link

Refactor for git-lite cli #11

Closed bwalsh closed 7 months ago

bwalsh commented 8 months ago

This PR:

This PR is one of a set:

bwalsh commented 8 months ago

@matthewpeterkort can you create an issue or expand on your comment in the your review here?

https://github.com/ACED-IDP/gen3_util/pull/42#issuecomment-1900967019

lbeckman314 commented 8 months ago

Preview site for this PR is available at https://feature-git-lite--luminous-boba-a6e270.netlify.app/

lbeckman314 commented 8 months ago

LGTM! Very minor UX question — do we prefer the navigation menu to be expanded on not on page load?

Expanded Nav

Screenshot 2024-01-22 at 11 23 04 AM

Collapsed Nav

Screenshot 2024-01-22 at 11 22 30 AM

netlify[bot] commented 8 months ago

Deploy Preview for luminous-boba-a6e270 ready!

Name Link
Latest commit af1551c564ca75f751fe5069df0efb75f1aaa83e
Latest deploy log https://app.netlify.com/sites/luminous-boba-a6e270/deploys/65b3b7cf4acbfd000805aa35
Deploy Preview https://deploy-preview-11--luminous-boba-a6e270.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

matthewpeterkort commented 8 months ago

@matthewpeterkort can you create an issue or expand on your comment in the your review here?

ACED-IDP/gen3_util#42 (comment)

Ok. https://github.com/ACED-IDP/aced-idp.github.io/issues/14